This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Isolating the git user and email into a UserSettingsView #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Merged
…ser-settings-view # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs
StanleyGoldman
force-pushed
the
enhancements/user-settings-view
branch
from
1c3ad0d to
89569bc
Compare
StanleyGoldman
force-pushed
the
enhancements/user-settings-view
branch
from
ec7718e to
344beec
Compare
shana
suggested changes
Sep 11, 2017
Member
shana
left a comment
shana
left a comment
There was a problem hiding this comment.
Yup this looks good! Got some minor nitpicks and a question that might require some code change.
|
|
||
| public override bool IsBusy | ||
| { | ||
| get { return ActiveView.IsBusy; } |
Member
There was a problem hiding this comment.
This change is probably a glitchy merge, the property should be at the bottom
| public override void OnDataUpdate() | ||
| { | ||
| base.OnDataUpdate(); | ||
| if (userSettingsView != null) |
Contributor
Author
There was a problem hiding this comment.
You are right, removing the null check
|
|
||
| public override bool IsBusy | ||
| { | ||
| get { return isBusy || userSettingsView.IsBusy; } |
# Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs
2 tasks
shana
approved these changes
Sep 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #251
#261 depends on this
Depends on:
Adding IsBusy to IView #273
Fix to update user name and email correctly in SettingsView #277
There are no visible changes to the UI as a result of this change
These changes also prevent the save of a blank name or email