Switch to AuthView on Publish API Failure

[StanleyGoldman]

Currently our only exposure to the API is PublishView. In the event of an authentication failure we need to switch the PublishView to the AuthenticationView

• If the user's authentication is not who we expect
  

-If there is no authentication present

• Sign In vs Publish
  

Depends on:

• Making sure favorites is not null #295
• Keeping the authentication if the username doesn't match in the keychain #298
• Fixes to keep the publish view from loading twice #299
• Fixing PublishView to support long error messages #361

[StanleyGoldman]

Do we need message to explain to the user that we need your authentication?
@shana @donokuda

[donokuda]

Do we need message to explain to the user that we need your authentication?

Yup, I'm 👍 in favor of explaining why they're taken to the authentication screen. Any strong feelings about checking first if they're signed in before displaying the publish form? If they're not logged in, then we could show them the sign-in form with a little error up on top:

I can push up an example branch if that helps!

[StanleyGoldman]

Cool. Thanks for the draft.
I think I got it, I'll let you know if I need more.

[donokuda]

Added back the header styles:

[shana]

Been thinking about this some more and talking to some people about what messages should say, and we should probably explain a bit more why we're doing this.

How about:

We've detected that your stored credentials are out of sync with your current user. This can happen if you have signed in to git outside of Unity. Sign in again to refresh your credentials.

[StanleyGoldman]

That sounds much better.

[shana]

All of these messages should be in const fields somewhere so we can localize them later

[shana]

I feel like this message is a bit unhelpful, especially given that it's the first thing they see right after clicking the button. When does this happen and is this our fault or the users'? If it's our fault, then we should followup with "Please sign in again" to tell them how to proceed here.

[StanleyGoldman]

It actually hasn't happened to me yet, so it would probably be best to leave the original exception message there instead.

[StanleyGoldman]

@donokuda I feel like the current auth view does not match the publish view. I think it was different before because you would completely leave the auth view and then separately enter the publish view. After these changes that will no longer be the case, one will flow into another.

Current Auth View:

Current Publish View:

Maybe it's just the lack of an invertocat that makes me feel like it's missing.

[donokuda]

Here's where this PR is at right now. It's ready for some feedback:

Sign in view with warning:

2FA view (is there a way to suppress that error if this is the first time viewing this screen?)

I also noticed when you hit "back" from the 2FA, it will still persist the error message even though it's not relevant to the screen before. Is there a way to prevent that from happening?

[shana]

I like this UI a lot, those message box styles rock!

I also noticed when you hit "back" from the 2FA, it will still persist the error message even though it's not relevant to the screen before. Is there a way to prevent that from happening?

We probably need to call Repaint/Redraw on the window to refesh the UI here

I wonder how we handle the Esc key. We should probably close the window and cancel the whole thing.

[StanleyGoldman]

Still need to work out what happens here..

[StanleyGoldman]

And here..

[StanleyGoldman]

Actually... the more I look at it this code will never run, PopupWindow and AuthenticationView already has us covered on this one.

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PublishView.cs

Lines 126 to 147 in b108e06

	var tokenUsernameMismatchException = exception as TokenUsernameMismatchException;
	if (tokenUsernameMismatchException != null)
	{
	Logger.Trace("Token Username Mismatch");
	var shouldProceed = EditorUtility.DisplayDialog(AuthenticationChangedTitle,
	string.Format(AuthenticationChangedMessageFormat,
	tokenUsernameMismatchException.CachedUsername,
	tokenUsernameMismatchException.CurrentUsername), AuthenticationChangedProceed, AuthenticationChangedLogout);
	if (shouldProceed)
	{
	//Proceed as current user
	}
	else
	{
	//Logout current user and try again
	}
	return;
	}

[shana]

omgomgomgomgomg this looks so awesome! 🎉 🚀

[StanleyGoldman]

Fixes #414