This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Added Unity DLLs path relative to Unity installation directory #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @mpOzelot ... thanks for the conbtribution! |
StanleyGoldman
previously requested changes
Oct 10, 2017
docs/contributing/how-to-build.md
Outdated
| - Copy [common/ApplicationInfo_Local.cs-example](../../common/ApplicationInfo_Local.cs-example) to `common/ApplicationInfo_Local.cs` and fill out the clientId/clientSecret fields for your application. | ||
|
|
||
| The build needs to reference `UnityEngine.dll` and `UnityEditor.dll`. These DLLs are included with Unity. If you've installed Unity in the default location, the build will be able to find them automatically. If not, copy these DLLs from your Unity installation into the `lib` directory in order for the build to work. | ||
| The build needs to reference `UnityEngine.dll` and `UnityEditor.dll`. These DLLs are included with Unity. If you've installed Unity in the default location, the build will be able to find them automatically. If not, copy these DLLs from `Unity/Editor/Data/Managed` into the `lib` directory in order for the build to work. |
Contributor
There was a problem hiding this comment.
So I think you have the right idea, but maybe we should make it the best of both worlds...
I was thinking...
copy these DLLs in
Unity/Editor/Data/Managedfrom your Unity installation into thelib
What do you think?
Member
There was a problem hiding this comment.
Yeah, we should be explicit about where things are. Would
copy these DLLs from `[your Unity installation path]\Unity\Editor\Data\Managed`
make sense to users? This is really only going to affect Windows users since on mac there's no way to tell the installer to install anywhere else.
Contributor
Author
There was a problem hiding this comment.
Yes, what you propose is even more clear.
shana
approved these changes
Oct 19, 2017
Member
|
Thank you @mpOzelot!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there are a lot of files called
UnityEngine.dllandUnityEditor.dll(probably they are all the same). Also figuring out how pull requests work.