This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Split event processing and process firing#368
Merged
StanleyGoldman merged 5 commits intofixes/repository-refactorfrom Oct 17, 2017
Merged
Split event processing and process firing#368StanleyGoldman merged 5 commits intofixes/repository-refactorfrom
StanleyGoldman merged 5 commits intofixes/repository-refactorfrom
Conversation
StanleyGoldman
suggested changes
Oct 16, 2017
| IndexChanged, | ||
| RemoteBranchDeleted, | ||
| RemoteBranchCreated, | ||
| RemoteBranchChanged, |
Contributor
There was a problem hiding this comment.
It's odd...
Remote branches never change... they only seem to delete and recreate...
Maybe we should remove this enum entry and that explains that fact?
Member
Author
There was a problem hiding this comment.
Hmmm, good point. Maybe if the branch gets deleted and created again, we should raise it as a change?
Contributor
|
I sent you a pull request #369 |
…r-events-tweak Using TryGet to fire events
StanleyGoldman
approved these changes
Oct 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ensure that we can control the order of events that get fired up from the watcher regardless of the order that they happen in in the file system. Also it should make it extra easy to test things.