Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

@StanleyGoldman
Copy link
Contributor

No description provided.

@shana
Copy link
Member

shana commented Oct 19, 2017

I took those calls out because neither view uses them, but now I notice GitPathView is using Enable. Disable is not being used by neither view, so no reason to add the overhead of calling those (unless you predict that they're going to be needed very soon?)

@StanleyGoldman
Copy link
Contributor Author

Okay, if they aren't being used that's fine with me.
I guess I was valuing convention over performance there.

@shana
Copy link
Member

shana commented Oct 20, 2017

It is a slippery slope though... if we add the override but we don't implement the call in the parent, then it won't ever be called and that might be confusing. What do you think, maybe having it there is more valuable for the programmer than not having it?

@StanleyGoldman StanleyGoldman merged commit 2987c08 into master Oct 20, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/init-view-bugs branch October 20, 2017 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants