This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Removing the extra InitializeRepository call #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
previously approved these changes
Oct 26, 2017
shana
suggested changes
Oct 26, 2017
| unityVersion = Application.unityVersion; | ||
| } | ||
| environment.Initialize(unityVersion, extensionInstallPath.ToNPath(), unityApplication.ToNPath(), unityAssetsPath.ToNPath()); | ||
| environment.InitializeRepository(!String.IsNullOrEmpty(repositoryPath) ? repositoryPath.ToNPath() : null); |
Member
There was a problem hiding this comment.
The call that should be removed is the one in DefaultEnvironment and not this one
StanleyGoldman
force-pushed
the
fixes/application-cache-double-call
branch
from
3eb3760 to
60528e7
Compare
shana
approved these changes
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplicationCachecallsDefaultEnvironment.InitializethenDefaultEnvironment.InitializeRepository.Meanwhile
DefaultEnvironment.InitiailizecallsInitializeRepositoryitself.