Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

@meaghanlewis
Copy link
Contributor

Working on simple scripts to run the tests on both Mac and Windows. Also added a how-to-test doc to describe the tests and how to run them.

I haven't scripted much, so feedback is appreciated!

@StanleyGoldman
Copy link
Contributor

I just tried this out on Windows. so far it seems to be working well..

My first thought is, since ./build.sh and build.cmd both build in Debug by default.
Maybe ./test.sh and test.cmd should both test in Debug by default as well.

@meaghanlewis
Copy link
Contributor Author

Thanks for the feedback @StanleyGoldman, so to test in Debug by default I can just set the configuration to Debug, right?

Meaghan Lewis and others added 2 commits November 3, 2017 16:06
Config parameter which is Debug by default.
Exclude parameter which is an empty string by default.
@meaghanlewis
Copy link
Contributor Author

thanks for your changes @StanleyGoldman

Adding some observations about running the tests on mac.

running ./test.sh results in:
packages\NUnit.Runners.2.6.4\tools\nunit-console.exe: command not found

when i try to run the nunit-console with mono (ex. mono packages/NUnit.Runners.2.6.4/tools/nunit-console.exe), it starts successfully

but when i run any tests (ex. mono packages/NUnit.Runners.2.6.4/tools/nunit-console.exe "build/IntegrationTests/IntegrationTests.dll") all the tests fail immediately and I see a lot of messages similar to this:
Method IntegrationTests.BaseIntegrationTest:TestFixtureSetUp ()' is inaccessible from method GitHub.Unity.Guard:set_InUnitTestRunner

screen shot 2017-11-07 at 1 25 17 pm

@meaghanlewis meaghanlewis changed the title [WIP] Add test scripts and documentation Add test scripts and documentation Nov 7, 2017
@StanleyGoldman StanleyGoldman mentioned this pull request Nov 9, 2017
1 task
@StanleyGoldman
Copy link
Contributor

So I have no idea yet how to make this run in mono, but I'm happy enough having it work on windows for now. I'm going to merge this in and add an issue for it.

@StanleyGoldman StanleyGoldman merged commit c2f64aa into master Nov 21, 2017
@StanleyGoldman StanleyGoldman deleted the enhancements/test-scripts branch November 21, 2017 18:22
@meaghanlewis
Copy link
Contributor Author

Thanks @StanleyGoldman for merging this and creating the test.sh issue 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants