This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Not attempting to serialize Texture2D objects and reloading Icons #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew-remove-serialized-texture2d
# Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/TreeControl.cs
I learned that is how we can tell Unity that Texture2D objects that were loaded during "game time" need to be retained after "game time" ends
…view-remove-serialized-texture2d
StanleyGoldman
force-pushed
the
fixes/branches-view-remove-serialized-texture2d
branch
from
c295c37 to
f98db05
Compare
Merged
15 tasks
3 tasks
StanleyGoldman
force-pushed
the
fixes/branches-view-remove-serialized-texture2d
branch
from
a7fbc49 to
03d85a8
Compare
StanleyGoldman
force-pushed
the
fixes/branches-view-remove-serialized-texture2d
branch
from
9cfa797 to
9dc931a
Compare
…ew-rollup' into fixes/branches-view-remove-serialized-texture2d # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/TreeControl.cs
StanleyGoldman
deleted the
fixes/branches-view-remove-serialized-texture2d
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This branch targets
enhancements/branches-view-rollup#464Texture2Dobjects and it is better to provide themOnEnable. A large component to this fix is the usage ofHideFlags.HideAndDontSavewhich prevents Unity from garbage collecting icons after they load during "game play".TreeintoBranchesTreein order to provide custom logic to set the icons for trees that represent a branch