Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Tree Style Reloading #507

Merged
StanleyGoldman merged 3 commits into from
Dec 5, 2017
Merged

Tree Style Reloading #507

StanleyGoldman merged 3 commits into from
Dec 5, 2017

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 5, 2017 •
edited
Loading

Note: This branch targets enhancements/branches-view-rollup #464

  • GetTextureFromColor is creating a texture which needs it's hideflags set.
  • Styles should not be serialized, otherwise we will need skin change detection to support the dark theme
  • Styles are only accessibly in OnGui

@StanleyGoldman
Adding functionality to update styles
e9d487e
@StanleyGoldman
Fixing styles that get used in the Tree
14d16fe 
Learned a few lessons here...
Style objects should only be created OnGui
Textures loaded from colors have a hideflag property too
@StanleyGoldman StanleyGoldman mentioned this pull request Dec 5, 2017
Merged
15 tasks
@StanleyGoldman StanleyGoldman merged commit d25963a into enhancements/changes-tree-view-rollup Dec 5, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/tree-style-reloading branch December 5, 2017 18:50
@StanleyGoldman StanleyGoldman restored the fixes/tree-style-reloading branch December 5, 2017 19:49
@StanleyGoldman StanleyGoldman deleted the fixes/tree-style-reloading branch December 5, 2017 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@drguthals drguthals Awaiting requested review from drguthals

@jcansdale jcansdale Awaiting requested review from jcansdale

1 more reviewer

@grokys grokys grokys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyGoldman @grokys