This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Refactoring Octorun output and authentication.js #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #621 we are treating the 422 status code as a signal that the password should be used as the token.
shana
reviewed
Mar 12, 2018
| return new LoginResultData(LoginResultCodes.Failed, "Failed.", host); | ||
| } | ||
|
|
||
| private async Task<string> TryContinueLogin( |
Member
There was a problem hiding this comment.
This method and the TryLogin method are exactly the same except for an error message, a flag and the extra line written to the process. Maybe dedupe this too?
Contributor
Author
There was a problem hiding this comment.
Consolidated
2 tasks
…o fixes/octorun-refactor-authentication # Conflicts: # octorun/src/authentication.js # octorun/src/bin/app-login.js # src/GitHub.Api/Tasks/OctorunTask.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #618
Fixes: #619
Fixes: #621