Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/GitHub.Api/Application/ApiClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -379,12 +379,19 @@ private async Task<bool> LoadKeychainInternal()
logger.Trace("LoadKeychainInternal: Loading");

//TODO: ONE_USER_LOGIN This assumes only ever one user can login
var uriString = keychain.Connections.First().Host;
var connection = keychain.Connections.First();
var uriString = connection.Host;

var keychainAdapter = await keychain.Load(uriString);
logger.Trace("LoadKeychainInternal: Loaded");

return keychainAdapter.Credential.Token != null;
var keychainUsername = keychainAdapter.Credential?.Username;
if (keychainUsername == null || connection.Username != keychainUsername)
{
throw new TokenUsernameMismatchException(connection.Username, keychainUsername);
}

return keychainAdapter.Credential?.Token != null;
}

logger.Trace("LoadKeychainInternal: No keys to load");
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub.Api/Authentication/Keychain.cs
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,6 @@ private void UpdateConnections(Connection[] conns)
public Connection[] Connections => connections.Values.ToArray();
public IList<UriString> Hosts => connections.Keys.ToArray();
public bool HasKeys => connections.Any();
public bool NeedsLoad => HasKeys && !string.IsNullOrEmpty(FindOrCreateAdapter(connections.First().Value.Host).Credential.Token);
public bool NeedsLoad => HasKeys && string.IsNullOrEmpty(FindOrCreateAdapter(connections.First().Value.Host).Credential?.Token);
}
}