This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Adding git fetch button #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
reviewed
Jul 5, 2017
| var fetchClicked = GUILayout.Button(FetchButtonText, Styles.HistoryToolbarButtonStyle); | ||
| GUI.enabled = true; | ||
| if (fetchClicked && | ||
| EditorUtility.DisplayDialog(FetchConfirmTitle, |
Member
There was a problem hiding this comment.
We probably don't need to ask for confirmation, fetch is a non-destructive operation, we can just do it.
shana
suggested changes
Jul 5, 2017
Member
shana
left a comment
shana
left a comment
There was a problem hiding this comment.
Added a little comment regarding the confirmation dialog (don't think we need it for non-destructive operations like fetch), otherwise 👍
shana
added a commit
that referenced
this pull request
Jul 6, 2017
StanleyGoldman
added a commit
that referenced
this pull request
Jul 6, 2017
Cleaning unused fields left over from PR #74
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #73