Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Conversation

@JanX2
Copy link

@JanX2 JanX2 commented Jan 12, 2014

The README was omitting the fact that xctool is a requirement for building Rebel.

The README was omitting the fact that xctool is a requirement for building Rebel.
@dannygreg
Copy link

This step should probably just be added to script/bootstrap rather than documenting it.

@jspahrsummers
Copy link
Contributor

@JanX2 Since the bootstrap script will explain the issue, will this change to the README actually be more helpful?

@dannygreg I don't think a bootstrap script on a random OSS project should install things via Homebrew. That should be up to the user, to install in whatever manner they choose.

@dannygreg
Copy link

I don't think a bootstrap script on a random OSS project should install things via Homebrew.

Isn't it's purpose to install dependencies though?

@jwilling
Copy link
Contributor

For what it's worth, is xctool really needed at all, if it's only used to pull down dependencies? I don't know much about how this bootstrap works (so feel free to ignore this comment), but I've always thought it odd that it needs a third-party build tool to do the job.

@jspahrsummers
Copy link
Contributor

@dannygreg The bootstrap script is meant to initialize the project and install local dependencies as required. I think we'd be a Bad Citizen™ to install something system-wide in script/bootstrap (especially because we tell everyone to run it after cloning).

@jwilling makes a good point too. xctool is really just for the cibuild script. It probably shouldn't even be mentioned in bootstrap.

@mdiep
Copy link
Contributor

mdiep commented Sep 15, 2015

This seems stale.

@mdiep mdiep closed this Sep 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants