Extra line included when `Open on GitHub` is called with a selection

[jcansdale]

• GitHub Extension for Visual Studio version: 2.5.5

NOTE: Use the keyboard rather than the mouse to select:

1. Select a range in the code editor
   
2. Right-click, GitHub > Open on GitHub

• Browser opens with extra line selected
  

Alternatively:

1. Select a range in the code editor
   
2. Right-click, GitHub > Copy link to clipboard
3. Right-click, GitHub > Open from clipboard

• An extra line is selected
  

[meaghanlewis]

Good catch!

[meaghanlewis]

Actually, I'm having a hard time reproducing this behavior. The right lines always seem to be highlighted for me.

[grokys]

@meaghanlewis i was able to repro by selecting the lines in @jcansdale's screenshots:

VisualStudio/src/GitHub.VisualStudio/Commands/CopyLinkCommand.cs

Lines 49 to 53 in 8651fe8

	Clipboard.SetText(link);
	var ns = ServiceProvider.TryGetService<IStatusBarNotificationService>();
	ns?.ShowMessage(Resources.LinkCopiedToClipboardMessage);
	await UsageTracker.IncrementCounter(x => x.NumberOfLinkToGitHub);
	}

[jcansdale]

Actually, I'm having a hard time reproducing this behavior. The right lines always seem to be highlighted for me.

You'll probably find this happens when using the keyboard rather than the mouse to select. The reason is that you'll tend to start (or end) the selection on the line below the selected area. If you start your selection at the bottom, this extra line will be completely invisible. If you start your selection at the top, this extra line will be obscured by the blinking caret.

I'm guessing that whoever tested this in the past used the mouse. Initially I was confused because it seemed to sometimes happen and sometimes not happen.

Does that make sense?