Correctly detecting VisualStudio version on 2017 and forward

[StanleyGoldman]

Recent metrics reporting showed that we are getting 15.0.0 consistently for Visual Studio.

https://developercommunity.visualstudio.com/content/problem/2813/cant-find-registry-entries-for-visual-studio-2017.html

We decided to use the following to get the version information for versions of Visual Studio after 2015.

var setupConfiguration = new SetupConfiguration();
var setupInstance = setupConfiguration.GetInstanceForCurrentProcess();
return setupInstance.GetInstallationName().TrimPrefix(InstallationNamePrefix);

Which will return something in the format of 15.5.2+27130.2010

[grokys]

Seems to work here. Returned value is 15.5.4+27130.2024. Assuming the stuff after the + is expected and wanted, LGTM!

[StanleyGoldman]

I have to update the body of this pull request, the approach has changed since it was first written up.

[StanleyGoldman]

Updated the body

[StanleyGoldman]

Fixes: #1434