Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented May 15, 2018

To incorporate editor-tools/Akavache#1 which is itself a cherry-pick of reactiveui/Akavache#407.

Use Task.Run to start OperationQueue's processing task rather than using the constructor and then calling task.Start. This ensures two things:

The TaskScheduler.Default scheduler is used, which will be a threadpool scheduler
That task tracks the running of the entire task: previously the task will have completed when it awaited as the Task constructor accepts an Action and not a Func<Task>

Fixes #1662.

@grokys grokys requested a review from jcansdale May 15, 2018 14:42
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm looking forward to using it. LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants