This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Don't prevent free users from creating private repos. #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcansdale
suggested changes
Jan 9, 2019
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Looks good and works well. 😄
Can we delete CanKeepPrivate, ShowUpgradePlanWarning, ShowUpgradeToMicroPlanWarning and UpgradeAccountPlan from the various Designer views?
jcansdale
approved these changes
Jan 9, 2019
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Looks good to me. LGTM!
jcansdale
reviewed
Jan 9, 2019
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Yey, commenting now works! 😄
| /// <summary> | ||
| /// If the repo can be made private (depends on the user plan) | ||
| /// </summary> | ||
| public bool CanKeepPrivate { get { return canKeepPrivate.Value; } } |
Collaborator
There was a problem hiding this comment.
Yey, commenting now works! 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub now allows unlimited free repositories for free users. Remove the code that prevented this.
🎉
Fixes #2164