This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Ensure that clone works when Visual Studio is first launched #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGitActionsExt is proffered by SccProviderPackage, but isn't advertised. To ensure that getting IGitActionsExt doesn't return null, we first request the SccService which is advertised. This forces SccProviderPackage to load and proffer IGitActionsExt.
prasethu
suggested changes
Feb 6, 2019
Force SccProviderPackage to load by getting IGitExt instead of the internal SccService.
StanleyGoldman
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
IGitActionsExtis proffered bySccProviderPackage, but isn't advertised. To ensure that gettingIGitActionsExtdoesn't return null, we first request theIGitExtwhich is advertised. This forcesSccProviderPackageto load and profferIGitActionsExt.How to test
Due to issues installing MEF components when testing using F5, I'd recomend installing this VSIX using DogfoodVsix.
Tools > Options...and setCurrent source control plug-intoNone.Clone or check out code > GitHubClonea repositoryTo do
Unfortunately Team Explorer / GitHub for Visual Studio doesn't notice that a GitHub repository has been loaded and the
GitHubsection doesn't appear on theTeam Explorer - Homepage.At least the clone works and the banner will appear next time the solution is loaded or the current branch changes. I don't think this is a ship blocker. I'll work on a fix in another PR.
Fixes #2218