This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Make comment margin appear on PR file view #2381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently new up PullRequestTextBufferInfo with Git relative path.
meaghanlewis
approved these changes
Jun 10, 2019
Contributor
meaghanlewis
left a comment
meaghanlewis
left a comment
There was a problem hiding this comment.
This LGTM. Thanks for the fix.
Collaborator
Author
|
This looks like a 🐛 Git uses |
jcansdale
force-pushed
the
fixes/2380-view-file-comment-margin
branch
from
1b42ef5 to
4f6b57e
Compare
co-authoried-by: Jamie Cansdale <jcansdale@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an individual file is opened from the PR detail view, the comment margin wasn't appearing.
What this PR does
How to test
View FileFixes #2380