Module Gradle/Java/CodeQL build fails due to "Unknown javac parameter: --add-opens"

[big-andy-coates]

I have Gradle Java projects that I'd love to use CodeQL to analyse. However, if I enable CodeQL either in its own workflow or integrated into the main build workflow, then the build fails with error:

Error: Exception in thread "main" Unknown javac parameter: --add-opens
	at com.semmle.extractor.java.args.JavaExtractorArgs.parse(JavaExtractorArgs.java:331)
	at com.semmle.extractor.java.JavaExtractor.<init>(JavaExtractor.java:187)
	at com.semmle.extractor.java.JavaExtractor.main(JavaExtractor.java:482)

The --add-opens command line option is being introduced by the org.javamodularity.moduleplugin Gradle plugin, which the project is using as its using Java's module system (a.k.a. Jigsaw).

However, its not javac that's complaining about the option, but com.semmle.extractor.java.args.JavaExtractorArgs.parse. The version of java the project is using supports the option. Looks like this could be an issue with the LGTM code...?

[aeisenberg]

It looks like you're relying on the autobuilder to trace the build as part of building the database. Can you try commenting out https://github.com/creek-service/creek-base/pull/17/files#diff-12783128521e452af0cfac94b99b8d250413c516ec71fe6d97dbea666ff7ba27R55-R56

And then uncomment https://github.com/creek-service/creek-base/pull/17/files#diff-12783128521e452af0cfac94b99b8d250413c516ec71fe6d97dbea666ff7ba27R65-R67 and change it to run the build commands for your specific project?

[big-andy-coates]

@aeisenberg I've tried both approaches. See creek-service/creek-base#16...

Though, I'm more than happy to make the above changes if it'll help with resolving this issue, i.e. if you don't think the pull 16 achieves the same as the changes you're suggesting.

[aeisenberg]

Thanks for letting me know. I heard from the team that supports the java extractor and, unfortunately, it looks like the add-opens flag is not supported. I'm waiting for clarification if there is a better workaround, but their current suggestion is to avoid using that option during code scanning.

[big-andy-coates]

@aeisenberg I'm lucky, in that its the test code that uses the add-opens options. So I guess I could just not compile and run the tests. Would CodeQL be happy with that?

[yo-h]

Thanks for filing this issue. This is an oversight in our Java extractor (the --add-opens flag is a hidden javac option). Our Java team will take a look at fixing this next week.

[yo-h]

So I guess I could just not compile and run the tests. Would CodeQL be happy with that?

I would expect that to work as a short-term workaround.

[big-andy-coates]

Thanks @yo-h.

[big-andy-coates]

FYI: Changing the build target to jar has the build passing: creek-service/creek-base#17

[aeisenberg]

Great. I'll close this issue. Feel free to open a new issue if you have any other issues.