This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Data flow: Allow nodes to be hidden from path explanations#176
Merged
max-schaefer merged 1 commit intogithub:masterfrom Jun 12, 2020
Merged
Data flow: Allow nodes to be hidden from path explanations#176max-schaefer merged 1 commit intogithub:masterfrom
max-schaefer merged 1 commit intogithub:masterfrom
Conversation
sauyon
approved these changes
Jun 11, 2020
Contributor
sauyon
left a comment
sauyon
left a comment
There was a problem hiding this comment.
LGTM. Does the fact that nodeIsHidden is in DataFlowPrivate mean that if we want to edit it we have to patch the shared file? Or am I mistaken in thinking that it's a shared file?
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf github/codeql#3657
Evaluation (internal link) shows no changes in results or performance.