JS: Treat res.end() as alias for res.send() in Express #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
previously approved these changes
Feb 28, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM.
(we could add a change note for this minor improvement)
I think we decided against using inheritance between NodeJS and Express way back.
The model of Connect explicitly use the inheritance, so I suspect we have a good reason not to use it for Express.
ghost
previously approved these changes
Feb 28, 2019
asger-semmle
force-pushed
the
express-end
branch
from
3901d71 to
2dc7f32
Compare
Contributor
Author
Added Express to the list of frameworks with improved support. |
Contributor
Author
|
Evaluation looks good. |
xiemaisi
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res.end works like res.send since it actually forwards to NodeJS's response.end method.
An alternative way to implement this would be to treat Express response objects as a subtype of NodeJS's HTTP response objects, since those already recognize the
endmethod. I'm not sure what the longterm benefits of that might be so I just took the easy way for now.Running evaluation on express.slugs.