Skip to content

Conversation

@asger-semmle
Copy link
Contributor

Evaluation on closure.slugs underway.

I included case-insensitive versions of string ops in the model since I can't think of a case(!) where our queries wouldn't want to treat them the same.

@asger-semmle asger-semmle added JS WIP This is a work-in-progress, do not merge yet! labels Feb 28, 2019
@asger-semmle asger-semmle requested a review from a team as a code owner February 28, 2019 16:55
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@asger-semmle
Copy link
Contributor Author

Evaluation looks good.

@asger-semmle asger-semmle removed the WIP This is a work-in-progress, do not merge yet! label Mar 1, 2019
@semmle-qlci semmle-qlci merged commit 6cafe22 into github:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants