C#: Model NHibernate framework #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
requested changes
Mar 4, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Good stuff, just two small comments.
|
|
||
| /** A mapped class that is mapped because it is used as a type argument. */ | ||
| private class MappedByTypeArgument extends MappedClass { | ||
| UnboundGeneric gen; |
| this = e.getType() | ||
| ) and | ||
| not this instanceof ObjectType and | ||
| not this.getABaseInterface*() instanceof SystemCollectionsIEnumerableInterface and |
Contributor
Author
There was a problem hiding this comment.
Sometimes, the argument could be a List or a Dictionary which isn't supposed to be mapped. This happened on the NHibernate-Core codebase anyway.
calumgrant
force-pushed
the
cs/nhibernate
branch
from
d552ec8 to
c3d0435
Compare
calumgrant
force-pushed
the
cs/nhibernate
branch
from
c3d0435 to
3fd10ec
Compare
hvitved
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows a very similar structure to #912, and is based on that PR. Only the last 2 commits need reviewing. Will resolve the merge conflict once #912 is merged.
Summary of changes:
SQLExprand therefore vulnerable to SQL injection.As usual, most of the work involves exploring and experimenting with the API. There are also XML specifications (
.hbm.xmlfiles) that specify the mapping, but in the end these files didn't appear to add much value.