JS: Add TypeTracking library #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiemaisi
approved these changes
Mar 7, 2019
xiemaisi
approved these changes
Mar 7, 2019
|
Internal testing revealed no changes to existing queries, so I'll merge without waiting for the evaluation to finish. |
Contributor
Author
|
Evaluation was indeed fine. |
|
It is worth noting that the imprecision of these no-change evaluations appear to be within 2%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the TypeTracking library from #1035, marked as experimental and intentionally unused by our own query suite.
Since it is unused, I don't expect any impact on performance, though I'm currently running an evaluation as a sanity check.
I'm targeting it for 1.20 so we can use it for custom query work once 1.20 is deployed. The plan is to migrate our own libraries as well, but that's obviously too risky for a hotfix.
Unlike in #1035, a separate
TypeBackTrackertype has been added to avoid spurious call/return matching when backtracking. It is disjoint fromTypeTracker, so it also prevents accidental use of.track()when back-tracking.