JavaScript: Fix two performance regressions in rc/1.20 #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiemaisi
force-pushed
the
js/performance-fiddling
branch
from
30cedab to
8e52528
Compare
ghost
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two independent fixes for mild regressions I spotted in the comparison run last weekend: the first commit downgrades
NewBrowserObjectfromTrackedNodetoSourceNode, thereby restricting it to local flow tracking only. This, in turn, allows us to model Electron IPC as a normalAdditionalFlowStep, which is cached (unlike theConfiguration-subclassing solution).While it's unfortunate to lose inter-procedural tracking, it hasn't found anything yet, and we'll soon be switching it to type tracking anyway, thereby regaining most of the global tracking. In the meantime it seems easier to push this out as a hotfix, since this part of the Electron library is new in 1.20.
The second commit is a refactoring in the data flow library that enables a better join order; it is entirely behaviour-preserving.
Evaluation (internal link) against rc/1.20 from a few days ago on
big-appslooks promising. I'd like to do another large-scale evaluation against 1.19 over the weekend, ideally including this fix.