JavaScript: Improve support for dynamic imports. #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yield import(...)` previously caused a syntax error, now it is parsed correctly. `parseYield` is the only place where the value of `startsExpr` matters, so this change should not affect anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yield import(...)previously caused a syntax error, now it is parsed correctly.parseYieldis the only place where the value ofstartsExprmatters, so this change should not affect anything else and hence seems safe as a hotfix.I have verified that this fix does not change the TRAP files produced for our default benchmark suite except for one test file in
test262(duplicated ingecko-dev) and another one inbabelthat explicitly exercise this syntax. These files now extract without syntax errors.Fixes #1105.