Shared: Add a qlpack with a parameterized module defining type-trackers. #11521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aschackmull
force-pushed
the
shared/typetracking
branch
from
bb87931 to
d38b226
Compare
aschackmull
force-pushed
the
shared/typetracking
branch
from
d38b226 to
27755d1
Compare
hvitved
requested changes
Dec 6, 2022
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Some minor comments, otherwise LGTM.
hvitved
approved these changes
Dec 6, 2022
| * `Node` and a `TypeTracker`. | ||
| */ | ||
| class PathNode extends TPathNode { | ||
| class PathNodeFwd extends TPathNode { |
Contributor
Author
There was a problem hiding this comment.
Otherwise I'll have to duplicate all its members. I thought a bit about coming up with a design that left this private, but this seemed the simplest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some followup work to be done here to allow a proper join-order in the call-graph-recursive case, but this should support the regular linear-recursive use-cases. (The interface has been prepared for this case mirroring the Ruby/Python setup.)
Note that for
TypeBackTracker.stepI've switched the meaning ofthisandresultto match the qldoc (keeping the existing order was simply too confusing). Since most use-cases are wrapped in the language-specificbacktrackpredicates then the switch should be easily adapted.