JS: fix getAPropertyAttribute timeouts #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
|
Thanks, please run a full evaluation (not just a slightly larger one) over the weekend. As far as I can tell, this problem arose because we weren't doing a full evaluation before, and I want to avoid that happening again. |
Author
|
Evaluation for this change is complete: there are no timeouts on |
|
OK, thanks for doing the eval. I'll wait with merging this until I've heard from the other language streams on whether the current distribution upgrade is otherwise good to go ahead. |
xiemaisi
approved these changes
Mar 25, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the recent timeouts by reverting the dataflow change of #1113.
I will run a slightly larger evaluation, but the problematic project no longer hits a timeout (https://git.semmle.com/esben/dist-compare-reports/tree/js/fix-define-property-regression_1553252658109).