JS: Fix flow through += #1214
Merged
JS: Fix flow through += #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiemaisi
approved these changes
Apr 5, 2019
xiemaisi
left a comment
xiemaisi
left a comment
There was a problem hiding this comment.
A pleasantly simple fix! LGTM modulo evaluation.
Contributor
Author
|
Evaluation looks ok. There is a slow down on one project which I haven't investigated further, as I would expect it's just from the increased reach of taint tracking. The new results seem like TPs except for the regexp ones, which are due to mismatched array indices when tracking taint through an array used as a tuple. I've opened ODASA-7893 to keep track of such FPs for when we want to fix the issue. I believe these particular FPs would go away after #1211 though. |
ghost
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when the next use of
xafterx += ewas not a value node.I remember trying to use
DataFlow::ssaDefinitionNodein the past and observing that it didn't work but was never able to figure out why. I've found the problem:StringConcatenationTaintStepextendedDataFlow::ValueNode.