JavaScript: Update TypeTracker to align with TypeBackTracker.
#1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now also has `step` and `smallstep` predicates. In the usual case, however, I think I prefer the `SourceNode::track` API, so I left the recommended style in the qldoc alone (and adjusted the one for `TypeBackTracker` to match).
ghost
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now also has
stepandsmallsteppredicates. In the usual case, however, I think I prefer theSourceNode::trackAPI, so I left the recommended style in the qldoc alone (and reverted the one forTypeBackTrackerto what it was before #1211). The reason is that when using thesteppredicate, the patterns forTypeTrackerandTypeBackTrackerbecome slighly asymmetric (different order oftandt2), which I think is confusing and error-prone.A full evaluation (internal link) shows a very slight slowdown overall, but nothing sticks out on the detailed profile.