JavaScript: Make autobuilder fail if no JS/TS code was seen. #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the autobuilder will no longer succeed for projects that contain HTML or YAML files but no JS/TS code. Further down the line, this prevents LGTM.com from classifying such projects as "JavaScript" projects.
ghost
self-assigned this
ghost
approved these changes
May 28, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM
When TRAP caching is turned on, we can't easily tell whether a file contained code or not, so we conservatively assume that it did. This only affects dist-compare (not LGTM), and only to the extent that extraction may trivially succeed.
Good to know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the autobuilder will no longer succeed for projects that contain HTML or YAML files but no JS/TS code. Further down the line, this prevents LGTM.com from classifying such projects as "JavaScript"
projects.
When TRAP caching is turned on, we can't easily tell whether a file contained code or not, so we conservatively assume that it did. This only affects dist-compare (not LGTM), and only to the extent that extraction may trivially succeed.