C#: More C# 8 features #1392
Merged
C#: More C# 8 features #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumgrant
force-pushed
the
cs/cs8/static-using-null
branch
from
3ea97d8 to
1da292a
Compare
hvitved
requested changes
Jun 4, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Awesome work! A few minor remarks.
| @@ -0,0 +1,2 @@ | |||
| description: Support for null-coalescing assignment, static local functions and using declarations. | |||
…iable, and extract modifiers for local functions.
…ockStmt` and a `UsingDeclStmt`.
calumgrant
force-pushed
the
cs/cs8/static-using-null
branch
from
1da292a to
9678f8e
Compare
calumgrant
force-pushed
the
cs/cs8/static-using-null
branch
from
c88359b to
98ecfd7
Compare
calumgrant
force-pushed
the
cs/cs8/static-using-null
branch
from
98ecfd7 to
a6ecb42
Compare
hvitved
reviewed
Jun 5, 2019
csharp/ql/test/query-tests/API Abuse/DisposeNotCalledOnException/DisposeNotCalledOnException.cs
Show resolved
Hide resolved
calumgrant
force-pushed
the
cs/cs8/static-using-null
branch
from
a6ecb42 to
c88359b
Compare
hvitved
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the remaining C# 8 features. (Missed feature freeze as it was queuing on the Language enum).
x ??= yusing file = File.Open(...);staticmodifiers on local functions