C++: Suspicious pointer scaling: @precision medium #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
previously approved these changes
Jun 5, 2019
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM. I'll give other people one last chance to comment before merging.
Contributor
|
And there's a merge conflict now... |
Contributor
|
Perhaps the change notes should indicate why the precision is being reduced? |
This query is not producing good enough results to justify `@precision high`. It's fundamentally looking for a pattern that should correlate with memory management errors, but it doesn't look for the errors themselves.
jbj
force-pushed
the
suspicious-pointer-scaling_medium
branch
from
5e2bbf3 to
cf96035
Compare
Contributor
Author
|
I've fixed the conflict and added justification to the change note. The wording is taken from how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query is not producing good enough results to justify
@precision high. It fundamentally looks for a pattern that should correlate with memory management errors, but it doesn't look for the errors themselves.I've wanted to take this query off LGTM for a long time. This forum post and the following Slack discussion is the occasion for doing it now.