JavaScript: PasswordInConfigurationFile tweaks
#1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 5, 2019 08:09
Only highlight first line, and include the password in the alert message.
In spite of recent improvements, this query is still too noisy to show by default.
ghost
reviewed
Jun 5, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM.
The delimiter change also affects TargetBlank.ql and DOM.qll, do we want a change note and/or a test for at least the former?
Author
Theoretically yes, but only for attributes whose value contains a newline. I don't think you can have that in plain HTML, though, so you have to get pretty creative in order for this to make a difference. In summary, I don't think it's likely to cause a user-visible change. |
ghost
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details; I think this qualifies as a hotfix, since YAML wasn't previously extracted by default, so the query had almost no results on LGTM.
No result changes on our default benchmarks.