JavaScript: Remove two remaining uses of TrackedExpr.
#1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The new expected test outputs look correct. |
ghost
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I removed all uses of
TrackedNode, I forgot aboutTrackedExpr. This PR removes its remaining two uses; performance is unaffected (internal link).I also noticed that the unpromoted-candidate queries still used
TrackedNodes, which seems wrong, so the second commit gets rid of that. This caused many changes in the expected test outputs for these queries, which I'm not sure I understand. @esben-semmle, perhaps you could comment on this?