C++: IR: InstructionSanity::duplicateOperand perf #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `InstructionSanity::duplicateOperand` predicate used `count` instead of `strictcount`. The 0-case of this `count` was as large as the Cartesian product of `Instruction` and `OperandTag`, which made `duplicateOperand` take forever to compute on large snapshots.
ian-semmle
approved these changes
Sep 11, 2018
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
Implement raw type extraction
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
PS: Simplify the AST in Powershell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InstructionSanity::duplicateOperandpredicate usedcountinstead ofstrictcount. The 0-case of thiscountwas as large as the Cartesian product ofInstructionandOperandTag, which madeduplicateOperandtake forever to compute on large snapshots.