JS: classify bundle files based on multiple license comments #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
as a 
Contributor
|
Shouldn't there be some updated test output for the new test case, though? |
Author
Amended with updated expected output. |
asger-semmle
approved these changes
Sep 11, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
AST synthesis framework (take 2)
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
Extract field declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the file classification for "bundles" by recognizing additional cases of files with multiple licenses.
See https://lgtm.com/query/1506557957580/ for the project that inspired the improvement.
See https://lgtm.com/query/1506534377937/ for the improvement on many projects.