Java/C#/C++: Add change notes for in/out barriers and barrierguards. #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
previously approved these changes
Aug 22, 2019
Contributor
|
The associated code changes for C#/C++ are coming in #1790. |
yh-semmle
previously approved these changes
Aug 23, 2019
Contributor
yh-semmle
left a comment
yh-semmle
left a comment
There was a problem hiding this comment.
LGTM, but needs conflict resolution.
aschackmull
force-pushed
the
java/changenotes-dataflow
branch
from
8209928 to
66ea665
Compare
jbj
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change note on barrier guards is only added for Java, as the feature is not yet enabled for the other languages.