Skip to content

Conversation

@raulgarciamsft
Copy link
Contributor

Change to cpp/overflow-buffer to detect access to an array using a negative index (static, out of range access, lower bound).

…gative index (static, out of range access, lower bound).
@ghost
Copy link

ghost commented Sep 13, 2018

CLA assistant check
All committers have signed the CLA.

@jbj jbj added the C++ label Sep 14, 2018
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

The test failure is caused by some test cases that were previously missed by the query, and are now caught, so results differed from those in the .expected file. That is, it's a positive change. Unfortunately it's from a subset of the tests that isn't in the public repo yet (we're working on it), but I'm very happy to merge this and update the .expected file internally.

@geoffw0 geoffw0 merged commit e4b9d31 into github:master Sep 14, 2018
@raulgarciamsft
Copy link
Contributor Author

Thanks a lot

@raulgarciamsft raulgarciamsft deleted the overflow_buffer_negindex branch September 14, 2018 21:10
@rdmarsh2 rdmarsh2 mentioned this pull request Sep 17, 2018
smowton pushed a commit to smowton/codeql that referenced this pull request Jan 17, 2022
Fix extraction of function references without dispatch receiver
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants