Go: Improve package-not-found diagnostic
#21213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
go/autobuilder/package-not-founddiagnostic based on experiences with the current version of it:severityWarning, users sometimes interpret it as an error and incorrectly assume that the Go analysis is not working at all.To address these points, I have made the following changes:
dynamicworkflows, the user is shown a link to the private registry docs. For other Actions workflows, they are told to add a step to configure access. For other environments, they are told to ensuregohas access.Since the diagnostic message now depends on the environment, I have updated the two affected integration tests to always pretend to run in an Actions environment.