C++: Suppress IntMultToLong alert on char-typed numbers #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects the existing QLDoc better and makes it more clear why it includes char-typed expressions.
geoffw0
approved these changes
Sep 24, 2018
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Seems reasonable. There's a slight danger we'll miss genuine errors when many chars are multiplied, or the result is stored in a short or something. But 'likelySmall' is a heuristic anyway and I expect this change will improve results.
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
make the package job depend on compile-queries
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
…in-extractor Prefer the Kotlin extractor's version of trap files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a small refinement on top of internal PR 25314 to address https://discuss.lgtm.com/t/cpp-integer-multiplication-cast-to-long-does-not-take-size-promotion-rules-into-account/1326/5.