Allow void* pointer arithmetic with sizeof #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically this isn't allowed by the C spec, but it's been seen in the wild: see https://lgtm.com/projects/g/libcsp/libcsp/snapshot/3763c7b3380f95c81636de5c95156fd3ef151a21/files/src/csp_buffer.c\#x1d04047d2bb68c21:1
geoffw0
approved these changes
Sep 25, 2018
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM. The tests for this query are still internal, so I've created an internal PR to add coverage for this case (https://git.semmle.com/Semmle/code/pull/28047).
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Model private methods and "main objects"
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
…ate-code Avoid duplicating generation of IrFile labels
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…e-story-2 PS: Cleanup upgrade/downgrade chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
voidis generally considered a 1-byte type when doing pointer arithmetic, these results are usually false positives.Technically this isn't allowed by the C spec, but it's been seen in the wild:
see https://lgtm.com/projects/g/libcsp/libcsp/snapshot/3763c7b3380f95c81636de5c95156fd3ef151a21/files/src/csp_buffer.c\#x1d04047d2bb68c21:1.
@geoffw0