Merge rc/1.18 into next. #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a snapshot of Postgres, evaluation of `getNextExplicitlyInitializedElementAfter#fff#antijoin_rhs#1` took forever, preventing the computation of the IR. I haven't been able to reproduce it with a small test case, but the implementation of `getNextExplicitlyInitializedElementAfter` was fragile because it called the inline predicate `ArrayAggregateLiteral.isInitialized`. It also seemed inefficient that `getNextExplicitlyInitializedElementAfter` was computed for many values of its parameters that were never needed by the caller. This commit replaces `getNextExplicitlyInitializedElementAfter` with a new predicate named `getEndOfValueInitializedRange`, which should have the same behavior but a more efficient implementation. It uses a helper predicate `getNextExplicitlyInitializedElementAfter`, which shares its name with the now-deleted predicate but has behavior that I think matches the name.
C++: IR: Fix performance of value-init ranges
With the new formulation, we can join on function and index at the same time, leading to significant performance gains on large code bases that use templates extensively.
These tests exercise the problematic cases where a variable can appear to have multiple types because of how we fail to account for qualified names when comparing type names.
Also exclude templates as their names are not canonical. The test changes in `isfromtemplateinstantiation/` are the inverses of what we got in 34c9892, which should be a good thing.
…ntry Parameter.qll: Tweak how effective declaration entries are computed
C++: more conservative resolveClass
We currently erroneously keep mentions of class instantiations, which can lead to bad performance on template-heavy code bases. We never want to link those anyway, so we can simply suppress them.
C++ definitions: Ignore type mentions of class inatantiations.
adityasharad
added
depends on internal PR
Contributor
|
Which internal PR corresponds with this? 28026 has been merged already. |
nickrolfe
approved these changes
Sep 26, 2018
Collaborator
Author
|
That's the one.
…--
Aditya Sharad
|
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
Extract expression body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables direct internal mergeback PR. This should be merged together with the corresponding internal PR. The tests on this PR can be ignored.
One minor conflict resolved: QLDoc for
hasCompleteTwininResolveClass.qll.