C#: Fix DB inconsistencies with extends/2 #2293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Nov 11, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
A small thing, and also a dist-compare run would be good.
| else ( | ||
| not this instanceof ObjectType and | ||
| result instanceof ObjectType | ||
| ) |
Contributor
There was a problem hiding this comment.
I would write
extend(this, getTypeRef(result))
or
not extend(this, _) and
not this instanceof ObjectType and
result instanceof ObjectType
…correctly give a base class of 'Object' when a base type is missing, which is often incorrect and can lead to db inconsistencies.
calumgrant
force-pushed
the
cs/extends-object
branch
from
f04e8f2 to
14e81e0
Compare
tamasvajk
reviewed
Aug 17, 2020
| or | ||
| not extend(this, _) and | ||
| not this instanceof ObjectType and | ||
| result instanceof ObjectType |
Contributor
There was a problem hiding this comment.
Why is this result instanceof ObjectType and not result = ObjectType?
Contributor
There was a problem hiding this comment.
The latter is not valid QL syntax, as the right-hand-side is a QL class and not an expression. result = any(ObjectType ot) would work, but instanceof is better IMO. Note that the extractor will guarantee that there is indeed only one element inside ObjectType.
Contributor
|
I had to make a similar change on #4017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a base class is unknown (due to a missing reference), Roslyn will incorrectly give a base class of
Object, which gets written to theextends/2table. This can cause DB inconsistencies. Instead, do not populateObjectas a base class, and instead deduce it in QL.