Skip to content

Definitions: Only emit links for canonical type mentions #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pavgust wants to merge 2 commits into from
Closed

Definitions: Only emit links for canonical type mentions #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a5f22
Definitions: Only emit links for canonical type mentions
pavgust Sep 27, 2018
382c7ef
Reintroduce definition links for template instantiations
pavgust Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions cpp/ql/src/definitions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,28 @@ private cached predicate constructorCallTypeMention(ConstructorCall cc, TypeMent
)
}

/**
* We sometimes produce many type mentions at the same location that
* refer to the same type. For the purposes of providing a definition
* link, we only want one of them.
*/
private module TypeMentions {
private
predicate identity(TypeMention a, TypeMention b) { a = b }

private
int id(TypeMention a) = equivalenceRelation(identity/2)(a, result)

private
TypeMention minMentionIdAt(Location l, Type t) {
result = min(TypeMention m | l = m.getLocation() and t = m.getMentionedType() | m order by id(m))
}

predicate isCanonical(TypeMention m) {
m = minMentionIdAt(_, _)
}
}

/**
* Gets an element, of kind `kind`, that element `e` uses, if any.
*
Expand Down Expand Up @@ -156,6 +178,7 @@ Top definitionOf(Top e, string kind) {
) or (
// type mention -> type
kind = "T" and
TypeMentions::isCanonical(e) and
e.(TypeMention).getMentionedType() = result and
not constructorCallTypeMention(_, e) and // handled elsewhere
// Multiple type mentions can be generated when a typedef is used, and
Expand All @@ -177,6 +200,7 @@ Top definitionOf(Top e, string kind) {
// - using the location of the type mention, since it's
// tighter that the location of the function call.
kind = "M" and
TypeMentions::isCanonical(e) and
exists(ConstructorCall cc |
constructorCallTypeMention(cc, e) and
result = cc.getTarget()
Expand Down