C++: Get rid of a fastTC and noopt in IR #2519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getAChild*` fastTC was causing OOM on a `make allyesconfig` Linux database with 8GB RAM, and I've observed it to be slow on other databases too.
Contributor
Author
|
By the way, the problematic TC was introduced by myself in #812. |
geoffw0
reviewed
Dec 17, 2019
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Changes LGTM. I've asked one question but it shouldn't be considered blocking.
I did experience a slight (7% / 2%) slowdown on the two projects I tested this with, but that's with just one IR query (RedundantNullCheckSimple.ql) and these numbers might not be significant. If you've done more extensive testing, I'm happy.
cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/IRConstruction.qll
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getAChild*fastTC was causing OOM on amake allyesconfigLinux database with 8GB RAM, and I've observed it to be slow on other databases too.