Skip to content

JavaScript: Update model of DOMException. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiemaisi merged 1 commit into from
Oct 1, 2018
Merged

JavaScript: Update model of DOMException. #257

xiemaisi merged 1 commit into from
Oct 1, 2018

Conversation

@xiemaisi
Copy link

@xiemaisi xiemaisi commented Oct 1, 2018

@xiemaisi xiemaisi added the JS label Oct 1, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner October 1, 2018 07:52
@xiemaisi
Copy link
Author

xiemaisi commented Oct 1, 2018

Unfortunately there isn't a good way of writing a unit test for this at the moment, but I've verified locally that it fixes the issue.

ghost
ghost approved these changes Oct 1, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiemaisi xiemaisi merged commit 7518267 into github:master Oct 1, 2018
@xiemaisi xiemaisi deleted the js/fix-DOMException-model branch October 4, 2018 09:35
@xiemaisi xiemaisi mentioned this pull request Oct 22, 2018
Merged
aibaars pushed a commit that referenced this pull request Oct 14, 2021
@hvitved
Merge pull request #257 from github/hvitved/cfg/erb
50cfd9c 
CFG: Allow `erb` top-level scopes
smowton added a commit to smowton/codeql that referenced this pull request Apr 16, 2022
@smowton
Merge pull request github#257 from github/smowton/feature/look-throug…
2474bc2 
…h-type-aliases

Quieten errors relating to generic type aliases
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
@ropwareJB
Merge pull request github#257 from microsoft/jb1/reapply-22.1-tmp
6d496ee 
Revert github#251, Reapply `codeql-cli/v2.22.1`
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 21, 2025
@ropwareJB
Revert "Merge pull request github#257 from microsoft/jb1/reapply-22.1…
f39c114 
…-tmp"

This reverts commit 6d496ee, reversing
changes made to 866977b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

JS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xiemaisi