JavaScript: Add support for Google Cloud Spanner. #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asger-semmle
left a comment
asger-semmle
left a comment
There was a problem hiding this comment.
Don't know anything about spanner, but LGTM modulo one typo.
| } | ||
|
|
||
| /** | ||
| * A call to `Trnsaction.run` or `Database.runStream`. |
Contributor
There was a problem hiding this comment.
Trnsaction -> Transaction
| * Gets the position of the query argument; default is zero, which can be overridden | ||
| * by subclasses. | ||
| */ | ||
| int getQueryArgumentPosition() { |
Contributor
There was a problem hiding this comment.
It's not actually overridden anywhere and the surrounding module is private. It looks like you opted for overriding getAQueryArgument instead.
Author
There was a problem hiding this comment.
Yes, this is a tiny bit of speculative generality.
xiemaisi
force-pushed
the
js/google-spanner
branch
from
cb9876b to
cd284b2
Compare
Author
|
Typo amended. |
ghost
previously approved these changes
Oct 15, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM.
There are two docstrings that optionally could use a minor improvement.
| } | ||
|
|
||
| /** | ||
| * A call to `Transaction.run` or `Database.runStream`. |
There was a problem hiding this comment.
Make this docstring more abstract? It looks exhaustive, but the predicate also supports runUpdate...
ghost
approved these changes
Oct 15, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Remove unused columns from tokeninfo tables
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Do not extract local function containers as anonymous classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick search didn't turn up any open-source projects that use it, so the model hasn't been tested on real-world code, only the unit tests.