Skip to content

Python: Format everything using qlformat. #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tausbn wants to merge 1 commit into from
Closed

Python: Format everything using qlformat. #3443

tausbn wants to merge 1 commit into from

Conversation

@tausbn
Copy link
Contributor

@tausbn tausbn commented May 11, 2020

Do you like whitespace changes?
I hope you like whitespace changes.

@tausbn tausbn added the Python label May 11, 2020
@tausbn tausbn requested a review from a team as a code owner May 11, 2020 16:08
@tausbn
Copy link
Contributor Author

tausbn commented May 11, 2020

Pro tip: click "Hide whitespace changes" before reviewing. 😉

@tausbn tausbn requested review from RasmusWL and removed request for a team May 11, 2020 16:15
RasmusWL
RasmusWL approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@RasmusWL RasmusWL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio 🚀

seems like some deprecation warnings in our .expected files needs to be fixed, but otherwise it LGTM!

@tausbn tausbn mentioned this pull request Jul 7, 2020
Merged
@tausbn
Copy link
Contributor Author

tausbn commented Jul 7, 2020

Superceded by #3915.

@tausbn tausbn closed this Jul 7, 2020
@tausbn tausbn deleted the python-qlformat-everything branch February 12, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RasmusWL RasmusWL RasmusWL approved these changes

Assignees

No one assigned

Labels

Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tausbn @RasmusWL